add inplace logic into new_executor #35618
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
Aurelius84
reviewed
Sep 15, 2021
| } | ||
| } | ||
|
|
||
| } // namespace |
There was a problem hiding this comment.
GetTensorFromVar 和 GetMutableTensorFromVar 在 paddle/fluid/framework/details/share_tensor_buffer_functor.cc里都有定义，这两个函数可以抽离到框架层面的utils里复用？
phlrain
reviewed
Sep 15, 2021
| @@ -243,6 +304,16 @@ void InterpreterCore::RunInstruction(const Instruction& instr_node) { | |||
| instr_node.kernel_func_.operator_base_) | |||
| ->InferShape(instr_node.infershape_ctx_.get()); | |||
|
|
|||
| if (FLAGS_new_executor_use_inplace) { | |||
There was a problem hiding this comment.
底层share了buffer之后，Variable的ref count也要增加； 因为out和input share了数据，如果out被其他op使用，这个inpute的数据就不能够提前释放
There was a problem hiding this comment.
底层share了buffer之后，Variable的ref count也要增加； 因为out和input share了数据，如果out被其他op使用，这个inpute的数据就不能够提前释放
这个不会的。share在Instruction前执行，此时In、Out分别持有share_ptr的holder。Instruction执行后，In交给GC后，GC只会减去share_ptr的一个RefCount，Out还能够继续正常持有holder。
liutiexing
approved these changes
Sep 15, 2021
phlrain
approved these changes
Sep 15, 2021
AnnaTrainingG
pushed a commit
to AnnaTrainingG/Paddle
that referenced
this pull request
Sep 29, 2021
* add inplace logic into new_executor, test=develop * check shape and add inplace FLAGS, test=develop * refine, test=develop * refine, test=develop
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
New features
PR changes
Others
Describe
添加inplace策略，inplace策略后，因为执行mutable_data的次数变少。显存有所下降，速度有所提升。
23.4s，20.4。1150M，1086M。